Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: videojs/video.js Loading
base: v8.17.2
Choose a base ref
...
head repository: videojs/video.js Loading
compare: v8.17.3
Choose a head ref
  • 6 commits
  • 8 files changed
  • 3 contributors

Commits on Jul 22, 2024

  1. fix: Refactor evented to make mincompatable with Chrome 53 (#8810)

    ## Description
    Chrome 53 doesn't like the minified output. Specifically, it throws
    `Uncaught SyntaxError: Unexpected token (` on the ternary in the
    minified version of `normalizeListenArgs()`
    
    https://github.com/videojs/video.js/blob/e78bcc7b2d829fce01451cf105b918d8feec4548/src/js/mixins/evented.js#L165-L195
    
    Line breaks added for clarify
    
    ```js
    Tt = (e, t, s) => {
      var i = t.length < 3 || t[0] === e || t[0] === e.eventBusEl_;
      let r, n, a;
      return i ? (r = e.eventBusEl_, 3 <= t.length && t.shift(), [n, a] = t) : [r, n, a] = t, ft(r, e, s), yt(n, e, s), bt(a, e, s), a = _(e, a), {
        isTargetingSelf: I,
        target: r,
        type: n,
        listener: a
      }
    },
    ```
    
    Chrome would be happy with this if `[r, n, a] = t` were `([r, n, a] =
    t)`.
    
    ## Specific Changes proposed
    Refactor `normalizeListenArgs()` slightly to use multiple statements to
    coerce uglify-js to include parentheses.
    Also updates uglify-js, but that in itself isn't the fix.
    
    Fixes #8783
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [x] Change has been verified in an actual browser - Browserstack
    Chrome 53
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [x] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    
    ---------
    
    Co-authored-by: Gary Katsevman <git@gkatsev.com>
    mister-ben and gkatsev committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a7c9f26 View commit details
    Browse the repository at this point in the history
  2. fix: Listen to taps on track controls (#8809)

    ## Description
    The refactored text track controls aren't listening for tap events.
    
    ## Specific Changes proposed
    Add tap handler to done and reset buttons.
    Fixes #8808
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [x] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [x] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    mister-ben committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    86d29cd View commit details
    Browse the repository at this point in the history
  3. fix(spatial-navigation): keep navigation going when player has an err…

    …or (#8805)
    
    ## Description
    The bug:
     Focus is lost when playback error is displayed.
    
    This small PR will update the spatial-navigation logic so when the error
    modal is shown the spatial-navigation will try to focus the components
    present in the error modal, in most cases this will be the vjs close
    button.
    
    ## Specific Changes proposed
    Keep navigation working when player shows the error modal by focusing a
    component in that modal.
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [ ] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [ ] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    CarlosVillasenor committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    76e99b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. fix(spatial-navigation): focus lost in error modal (#8817)

    ## Description
    The spatial-navigation is unable to focus certain elements of the error
    modal when this appears, this PR will fix that
    
    ## Specific Changes proposed
    Allow the spatial-navigation to focus certain non-component elements in
    the error modal
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [ ] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [ ] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    CarlosVillasenor committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    daf40bd View commit details
    Browse the repository at this point in the history
  2. fix(spatial-navigation): refocus available also to the close button o…

    …f the error modal (#8819)
    
    ## Description
    This PR will make the refocus available not only to the buttons of the
    error modal but also to the close button of the error modal on the event
    of 'aftermodalfill'.
    
    ## Specific Changes proposed
    Allow the spatial-navigation to refocus the error modal when error modal
    appears.
    
    ## Requirements Checklist
    - [x] Feature implemented / Bug fixed
    - [ ] If necessary, more likely in a feature request than a bug fix
    - [ ] Change has been verified in an actual browser (Chrome, Firefox,
    IE)
      - [ ] Unit Tests updated or fixed
      - [ ] Docs/guides updated
    - [ ] Example created ([starter template on
    JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
    - [ ] Has no DOM changes which impact accessiblilty or trigger warnings
    (e.g. Chrome issues tab)
      - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
    - [ ] Reviewed by Two Core Contributors
    CarlosVillasenor committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    45570d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. 8.17.3

    CarlosVillasenor committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c4007db View commit details
    Browse the repository at this point in the history
Loading