Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 3 commits
- 5 files changed
- 3 contributors
Commits on Jun 1, 2024
-
fix: removes duplicate id in text track settings (#8755)
## Description Prevents a duplicate id in text track settings. Fixes #8754 ## Specific Changes proposed The text edge settings were erroneously duplicating the id generated for the background colour. Changes to a unique name. Adds a general test for duplicate ids. ## Requirements Checklist - [x] Feature implemented / Bug fixed - [ ] If necessary, more likely in a feature request than a bug fix - [x] Change has been verified in an actual browser (Chrome, Firefox, IE) - [x] Unit Tests updated or fixed - [ ] Docs/guides updated - [ ] Example created ([starter template on JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0)) - [x] Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab) - [x] Has no changes to JSDoc which cause `npm run docs:api` to error - [ ] Reviewed by Two Core Contributors
Commits on Jun 6, 2024
-
update xhr to 2.7.0 Co-authored-by: Dzianis Dashkevich <ddashkevich@brightcove.com>
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v8.14.1...v8.15.0