use map instead of forEach

videojs · Jan 23, 2023 · 92a9243 · 92a9243
1 parent f575b2a
commit 92a9243
Showing 1 changed file with 8 additions and 15 deletions.
diff --git a/lib/mp4/probe.js b/lib/mp4/probe.js
@@ -377,22 +377,15 @@ getTracks = function(init) {
  */
 getEmsgID3 = function(segmentData, ptOffset = 0) {
   var emsgBoxes = findBox(segmentData, ['emsg']);
-  var emsgID3Data = [];
-  emsgBoxes.forEach(function(data) {
-      var boxData = new Uint8Array(data);
-      var parsedBox = emsg.parseEmsgBox(boxData);
-      var pts = emsg.scaleTime(parsedBox.presentation_time, 
-                          parsedBox.timescale, 
-                          parsedBox.presentation_time_delta, 
-                          ptOffset);
-      var duration = emsg.scaleTime(parsedBox.event_duration, parsedBox.timescale);
-      emsgID3Data.push({
-          pts,
-          duration,
-          data: parsedBox.message_data,
-      });
+  return emsgBoxes.map((data) => {
+    var boxData = new Uint8Array(data);
+    var parsedBox = emsg.parseEmsgBox(boxData);
+    return {
+      pts: emsg.scaleTime(parsedBox.presentation_time, parsedBox.timescale, parsedBox.presentation_time_delta, ptOffset),
+      duration: emsg.scaleTime(parsedBox.event_duration, parsedBox.timescale),
+      data: parsedBox.message_data
+    };
   });
-  return emsgID3Data;
 };
 
 module.exports = {