fix(spatial-navigation): keep navigation going when player has an error #8805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8805 +/- ##
==========================================
+ Coverage 83.07% 83.78% +0.71%
==========================================
Files 120 120
Lines 8022 8080 +58
Branches 1925 1939 +14
==========================================
+ Hits 6664 6770 +106
+ Misses 1358 1310 -48 ☔ View full report in Codecov by Sentry. |
…red an object to execute its logic
…mponents is called
dzianis-dashkevich
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug:
Focus is lost when playback error is displayed.
This small PR will update the spatial-navigation logic so when the error modal is shown the spatial-navigation will try to focus the components present in the error modal, in most cases this will be the vjs close button.
Specific Changes proposed
Keep navigation working when player shows the error modal by focusing a component in that modal.
Requirements Checklist
npm run docs:apito error