Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AudioTrackKind misalignment re description(s) #8769

Closed
david-hm-morgan opened this issue Jun 14, 2024 · 4 comments · Fixed by #8770 · May be fixed by kerasus/soalaa#1707
Closed

AudioTrackKind misalignment re description(s) #8769

david-hm-morgan opened this issue Jun 14, 2024 · 4 comments · Fixed by #8770 · May be fixed by kerasus/soalaa#1707

Comments

@david-hm-morgan
Copy link
Contributor

video.js/src/js/control-bar/audio-track-controls/audio-track-menu-item.js

Line 54 in 6b468dd

if (['main-desc', 'description'].indexOf(this.options_.track.kind) >= 0) {

This should be plural descriptions in order to align with

export const AudioTrackKind = {
  'alternative': 'alternative',
  'descriptions': 'descriptions',
  'main': 'main',
  'main-desc': 'main-desc',
  'translation': 'translation',
  'commentary': 'commentary'
};

https://github.com/videojs/video.js/blob/6b468dd2a959ebcb1a2540fb08128ae4f52b01b0/src/js/tracks/track-enums.js#L28C1-L35C3
@welcome Welcome
Copy link

welcome bot commented Jun 14, 2024

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

This was referenced Jun 14, 2024
Closed
Merged
@AdityaGupta-cyber
Copy link

Hello,
If the issue still persists, then I would like to work on this open issue.

@david-hm-morgan
Copy link
Contributor Author

Hello, If the issue still persists, then I would like to work on this open issue.

Hi @AdityaGupta-cyber I've already proposed a PR #8770

@AdityaGupta-cyber
Copy link

Hi @david-hm-morgan I would love to connect and learn more about how do you plan to close this issue and work on the bug, I have already connected with you on twitter(now X). Please let me know.

@kerasus kerasus mentioned this issue Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@david-hm-morgan @AdityaGupta-cyber