Skip to content

Commit

Permalink
fix: Listen to taps on track controls (#8809)
Browse files Browse the repository at this point in the history
## Description
The refactored text track controls aren't listening for tap events.

## Specific Changes proposed
Add tap handler to done and reset buttons.
Fixes #8808

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [x] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [x] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [x] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors
  • Loading branch information
mister-ben committed Jul 22, 2024
1 parent a7c9f26 commit 86d29cd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/js/tracks/text-track-settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,12 @@ class TextTrackSettings extends ModalDialog {
}

bindFunctionsToSelectsAndButtons() {
this.on(this.$('.vjs-done-button'), 'click', () => {
this.on(this.$('.vjs-done-button'), ['click', 'tap'], () => {
this.saveSettings();
this.close();
});

this.on(this.$('.vjs-default-button'), 'click', () => {
this.on(this.$('.vjs-default-button'), ['click', 'tap'], () => {
this.setDefaults();
this.updateDisplay();
});
Expand Down

0 comments on commit 86d29cd

Please sign in to comment.