Fix: seeking is broken on smart TV. #6414
Conversation
src/js/utils/dom.js
Outdated
| // `mouseup` event on a single left click and | ||
| // `mousedown` event on pressing a button on the remote controller (Samsung TV) | ||
| // have `button` and `buttons` equal to 0 | ||
| if ((event.type === 'mouseup' || event.type === 'mousedown') && |
There was a problem hiding this comment.
Wonder if we should be adding a click type here too.
Also, whether this affects regular browsers and whether they will now preferentially treat mousedown as the click event rather than mouseup. I guess it depends on how isSingleLeftClick is used specifically. But it could have potential implications on accessibility.
There was a problem hiding this comment.
Yes, this is a 'dirty' hack that works but complicates the code and can introduce side effects on some exotic devices. I think it will be better to revert this code changes inside the 'isSingleLeftClick' function and do the change inside the seekbar component itself. Does it sound better for you?
There was a problem hiding this comment.
yeah, that does sound like a better approach. Keep hacks as contained as possible 🙂
There was a problem hiding this comment.
I have just updated the PR. Does it look better now?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
gkatsev
added
pinned
brandonocasey
added
needs: discussion
misteroneill
added
needs: updates
and removed
needs: discussion
Description
A proposed fix for #6273
Requirements Checklist