Using src attribute instead of source element #5701
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
|
Thanks for your patience, finally had time to look at this. I think you actually figured out a good way of doing it, you just needed to tweak it a bit. I'll make a PR against your branch with the changes to get it to work. |
|
I made a PR against your branch over here https://github.com/BVFernandes/video.js/pull/1/files?utf8=%E2%9C%93&diff=unified&w=1 |
|
@BVFernandes did you want to merge my PR? https://github.com/BVFernandes/video.js/pull/1/files?utf8=%E2%9C%93&diff=unified&w=1 |
|
There are still pending issues with the changes in #5762, going to close this PR for now. |
Description
Possible fix to issue #4851 by using src attribute to generate the source element when the last is undefined.
Specific Changes proposed
In the loader.js, I tried modify the player data structure to add the source object (with src and type) using simply the src attribute, when the video-js class is created in the index.html file. But, sadly, it doesn't work, because the playerOptions object is edited and not the player object.
Requirements Checklist