Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onclue is never called if the vtt file does not end with 2 blank lines #391

Open
evs-jjam opened this issue Jan 22, 2024 · 0 comments
Open

onclue is never called if the vtt file does not end with 2 blank lines #391

evs-jjam opened this issue Jan 22, 2024 · 0 comments

Comments

@evs-jjam
Copy link

vtt.js/lib/vtt.js

Line 1286 in 42ca104

self.oncue && self.oncue(self.cue);

self.oncue is never called if the last line is a single blank line instead of two.

A workaround I found is to add a couple of extra blank lines systematically as this does not seem to cause any undesired side effects but that feels very hacky.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@evs-jjam