Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cue position to auto, fix tests #359

Merged
merged 6 commits into from
Dec 1, 2016
Merged

Default cue position to auto, fix tests #359

merged 6 commits into from
Dec 1, 2016

Conversation

johnBartos
Copy link
Contributor

Default cue position to auto, fix tests
ffaf69c 
Replace jshitnt ask

Replace space
@johnBartos johnBartos mentioned this pull request Nov 28, 2016
Closed
@johnBartos
Copy link
Contributor Author

@rillian

This was referenced Dec 1, 2016
Merged
Open
@rillian
Copy link
Contributor

rillian commented Dec 1, 2016

Thanks for fixing this up!

@rillian rillian merged commit 3078a05 into mozilla:master Dec 1, 2016
gkatsev added a commit to videojs/vtt.js that referenced this pull request Apr 1, 2019
@gkatsev
fix position and size defaults. See mozilla/vtt.js#359
93c9421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnBartos @rillian