Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default cue.position to "auto" #355

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Default cue.position to "auto" #355

merged 1 commit into from
Nov 16, 2016

Conversation

johnBartos
Copy link
Contributor

Fixes #354

rillian
rillian approved these changes Nov 16, 2016
View reviewed changes
Copy link
Contributor

@rillian rillian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rillian rillian merged commit 52bf0a9 into mozilla:master Nov 16, 2016
@johnBartos johnBartos mentioned this pull request Nov 21, 2016
Closed
@MattiasBuelens
Copy link

MattiasBuelens commented Nov 22, 2016 •
edited
Loading

FYI: this PR changed dist/vtt.js rather than lib/vtt.js (see diff). As such, the changes from this PR will be lost whenever a new distribution is built.

Usually, PRs should not change files in dist. You probably want to port these changes to lib/vtt.js, and have the maintainer build a new distribution when releasing a new version.

johnBartos added a commit to johnBartos/vtt.js that referenced this pull request Nov 22, 2016
@johnBartos
Default cue.position to auto - in the right file
9917027 
PR'd this mozilla#355 against dist by mistake.
@johnBartos johnBartos mentioned this pull request Nov 22, 2016
Closed
@johnBartos
Copy link
Contributor Author

Oops, thanks @MattiasBuelens! #357

@rillian
Copy link
Contributor

rillian commented Nov 22, 2016

@MattiasBuelens Forgive my ignorance, but why are the dist versions in version control at all?

@gkatsev
Copy link
Contributor

gkatsev commented Nov 22, 2016

Bower requires that the dist be checked in or at least available in the tag.
In videojs, we have a custom build that when we want to do a release, it tags the version in a separate branch that doesn't get merged back into master. Don't necessarily recommend this approach, but that's how we solved it.

@rillian
Copy link
Contributor

rillian commented Nov 22, 2016

Wierd. Ok, thanks.

@rillian rillian mentioned this pull request Nov 22, 2016
Merged
@johnBartos johnBartos mentioned this pull request Nov 28, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rillian rillian rillian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnBartos @MattiasBuelens @rillian @gkatsev