Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionalize Navigator access #347

Merged
merged 2 commits into from
Dec 1, 2015
Merged

Conditionalize Navigator access #347

merged 2 commits into from
Dec 1, 2015

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Nov 29, 2015

@rillian
Copy link
Contributor Author

rillian commented Nov 29, 2015

@RickEyre does this look reasonable to you?

@rillian
Conditionalize the navigator IE8 check.
d14bb80 
This caused a problem in gecko, where the jsm runs in an
environment without access to the navigator object.
@rillian
Rebuild dist.
45e3a53
@rillian
Copy link
Contributor Author

rillian commented Nov 30, 2015

New push uses typeof per Jesse Ruderman's suggestion. Matches what we do for other existence checks.

@rillian
Copy link
Contributor Author

rillian commented Dec 1, 2015

r? @kinetiknz

Can you review this for me please?

@kinetiknz
Copy link

LGTM r+

rillian added a commit that referenced this pull request Dec 1, 2015
@rillian
Merge pull request #347 from rillian/navigator
9b27cb6 
Conditionalize Navigator access
@rillian rillian merged commit 9b27cb6 into mozilla:master Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rillian @kinetiknz