Switch the RTL characters array to a ranges array #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gkatsev awesome! Can you squash the two commits? We don't want any broken builds. Looks good after that. |
|
Sure. |
gkatsev
force-pushed
the
strong-rtl-characters
branch
from
b6521c2
to
04cd8c8
Compare
Not having the complete array in the source but instead, just the possible ranges has a size saving of about 15Kb. In addition, usage was change to a function called 'isStrongRTLChar' which makes the code clearer and more readable.
|
Squashed. |
|
@RickEyre hey, any updates on this? Thanks! |
|
Any updates on this? |
|
@RickEyre said it looks good and it passes tests, so merging. |
|
Sweet! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having the complete array in the source but instead, just the
possible ranges has a size saving of about 15Kb.
In addition, usage was change to a function called 'isStrongRTLChar'
which makes the code clearer and more readable.